Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v6.0.0 #385

Merged
merged 118 commits into from
Nov 9, 2017
Merged

Release v6.0.0 #385

merged 118 commits into from
Nov 9, 2017

Conversation

kattrali
Copy link
Contributor

@kattrali kattrali commented Oct 30, 2017

Supercedes the previous PR (#320), merging all changes together.

Todo

  • one last check through all the examples
  • update changelog (and cross-link the upgrading guide)

kattrali and others added 15 commits October 12, 2017 15:34
When calling to_s will raise, rescue and insert a placeholder.
If a ActionDispatch::RemoteIp instance cannot be memoized, it throws an
IpSpoofAttackError from to_s. In this case, replace the IP with a
placeholder.

Ref:
https://github.com/rails/rails/blob/34fe2a4fc778d18b7fe6bdf3629c1481bee789b9/actionpack/lib/action_dispatch/middleware/remote_ip.rb#L134
NameError: uninitialized constant Report::UNHANDLED_EXCEPTION_MIDDLEWARE
In newer versions of Ruby using File.exists? will warn about deprecation. The
File.exist? method has been around forever so this will not introduce any
backwards compatibility problems.
@Cawllec Cawllec merged commit 9404f63 into master Nov 9, 2017
@Cawllec Cawllec deleted the kattrali/v6 branch February 7, 2018 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants